linebender/druid

File Open dialog issue

Open

#115 opened on 2019年8月9日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)Rust (9,091 stars) (567 forks)batch import
bughelp wanted

説明

I'm having issues combining File Open dialogs and timers in the druid-shell hello example.

Currently File Open dialogs block while holding a mutable borrow on the WinHandler until the dialog comes back with a result path. If a timer event triggers while the dialog is open, it panics with "already borrowed".

#95 mentions a possible solution. Are there other solutions to consider?

As a workaround for now I don't block when opening the dialog, immediately returning an Err(Error:Null) in get_file_dialog_path and I have a closure that runs with the actual result but I'm not sure where to send it. If a solution is decided upon I can take a shot at a PR.

コントリビューターガイド

技術スタック
rust
領域
desktop
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Rust borrowing fundamentalsdruid shell basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
The issue describes a conflict between file dialog blocking and timer events due to mutable borrow on WinHandler. The comment references issue #95 which may have a solution. The contributor could investigate #95 and propose a non blocking approach, such as using channels or callbacks. The workaround mentioned (immediately returning Err and using a closure) could be a starting point. Files to examine include the druid shell hello example and the get file dialog path method.