line/armeria

Consider to remove sorting at MeterIdPrefix

クローズ

#2,150 opened on 2019/10/03

 (10 件のコメント) (0 件のリアクション) (0 人の担当者)Java (863 件のフォーク)batch import
good first issueperformance

Repository metrics

Stars
 (4,552 個のスター)
PR merge metrics
 (平均マージ 5d 12h) (30d で 42 merged PRs)

説明

Currently, we sort the micrometer tags at MeterIdPrefix to create Meter ID stably. https://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/common/metric/MeterIdPrefix.java#L95-L101

Since I saw this stacktrace from our service’s flamegraph, I would like to consider whether it is avoidable or not. Since it doesn’t have many samples, we can be ignored but because it is not optimal, it would be happy if we can avoid this sort.

コントリビューターガイド