lenra-io/lenra_components

Is 'utils' belongs to this library ?

オープン

#7 opened on 2021/08/18

 (4 件のコメント) (0 件のリアクション) (0 人の担当者)Dart (0 件のフォーク)auto 404
help wantedinvalidquestion

Repository metrics

Stars
 (4 個のスター)
PR merge metrics
 (PR metrics pending)

説明

There is a folder 'utils' that give some helpers to :

  • parse a color
  • validate textfield input (password/email)

The color parser is not used by the library. It is just exposed as part of the lib. The validator is partially used by the lenra_text_form_field.dart component to check the value of the input based of the type parameter (email or password).

I think we can safely remove the color parser but i'm not sure about the validator :

  • Is it our job to check the value of the input ? If not, we should remove the validator.
  • If it is our job, we should provide a way for the user to completely override the validator (not just add on top of the existing validator).
  • Should we add more types in the futur ? (phone number, address...)

@lenra-io/lenra any thought ?

コントリビューターガイド