lbryio/lbry-sdk

Add type to supports data

Open

#919 opened on 2017年9月22日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)Python (7,220 stars) (500 forks)batch import
area: jsonrpchelp wantedlevel: 1type: improvement

説明

The Issue

Currently, when you list claim information (claim_list_mine/claim_show/resolve/claim_list) that shows supports, you can't tell if it's a classical support or a tip. We should add a type attribute to each support. If someone sends a tip to themselves, it's treated the same way as a classical support, so not sure which way it needs to be captured.

This will be an important field to report of off for search results and have available in the block explorer.

Expected behaviour

Support should show if it's a tip or not

Actual behaviour

Can't tell if support is a tip or classic support

コントリビューターガイド

技術スタック
python
領域
blockchainbackend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
needs investigation
前提条件
Basic PythonUnderstanding of LBRY claim data model
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Review the current support data structure in the LBRY SDK, likely in files such as `lbry/schema/claim.py` or similar. Check existing comments in issue #919 for any proposed approaches. Determine where support objects are created and how the 'type' field should be integrated. Update serialization and deserialization to include the new field, ensuring backward compatibility.