lbryio/lbry-sdk

Ensure that default download directory is writable on daemon startup

オープン

#3,270 opened on 2021/04/20

 (10 件のコメント) (0 件のリアクション) (0 人の担当者)Python (500 件のフォーク)batch import
area: downloadsgood first issuehelp wantedtype: improvement

Repository metrics

Stars
 (7,220 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Creating a new issue based on lbryio/lbry-sdk#877

  • Update ensure_directory_exists() to check that the directory is writable by the current process.
  • If it's not, return a useful error
  • Add tests to cover the case when
    • download directory does not exist
    • download dir exists but is not writable
    • dir exists and is writable
    • the path refers to a file not a directory

bonus: also check if disk is full when sdk starts. this check should be outside ensure_directory_exists(). it probably goes somewhere near here

コントリビューターガイド