lbryio/lbry-desktop

The mute icon sometimes does not reflect actual state.

Open

#4,358 opened on 2020年6月9日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (3,596 stars) (412 forks)batch import
area: viewerhelp wantedtype: bug

説明

Bug The mute icon in the player does not reflect the actual state for this scenario. It's very minor, but would probably impact the "tap to unmute" feature request.

To Reproduce

  1. Open a video and mute it.
  2. Click Back and close the floating player.
  3. Open another video, and click to play (I had "autoplay" set to off). It should then start as muted, and if not, repeat 1 and 2 again.
  4. Press 'm' to unmute. You'll hear the sound, but icon stays as "muted". You might need to wiggle the mouse to keep the controls visible.

If you enter into a video claim with audio played directly, then the 'm' button is in sync with the icon when pressed.

Expected behavior Icons need to reflect actual state.

System Configuration 0.46.1 yarn build, but also seen in lbry.tv today.

コントリビューターガイド

技術スタック
javascriptelectronreact
領域
frontenddesktop
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
React state managementElectron basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
85
調査方針
The bug occurs in the mute icon within the player UI. Look for the component handling the mute button (likely in src/renderer/player/). The mute state is not synced when pressing 'm' after the sequence described. Check the keypress event handler and ensure the icon's state is updated based on the actual mute status. The issue is isolated and well reproduced.
The mute icon sometimes does not reflect actual state. · lbryio/lbry-desktop#4358 | Good First Issue