lbryio/lbry-desktop

Full screen (f11) does not work for games (PDFs and images also)

Open

#2,267 opened on 2019年2月5日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (3,596 stars) (412 forks)batch import
area: uxhelp wantedlevel: 2

説明

The Issue

When playing Unity games the app will not get in the full-screen mode (F11).

@tzarebczan mentioned that it also doesn't work for PDFs and images.

Could be related to: https://github.com/lbryio/lbry-desktop/issues/1815

Steps to Reproduce

Load a game from lbry://OpenSourceGames and try to get into full screen.

System Configuration

  • LBRY Daemon version: 0.30.4
  • LBRY App version: 0.28.0-rc.4
  • LBRY Installation ID:
  • Operating system: win 10

コントリビューターガイド

技術スタック
javascriptreact
領域
desktop
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
needs investigation
前提条件
familiarity with Electronunderstanding of fullscreen API
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
25
調査方針
The issue reports that F11 fullscreen doesn't work for games, PDFs, and images in the LBRY desktop app. Start by examining the Electron fullscreen implementation in the app, focusing on how webviews or browser windows handle fullscreen events. Check the referenced issue #1815 for possibly related context. Reproduce the bug using the steps provided (a Unity game from LBRY). Look at the Electron documentation for the fullscreen API and consider if the issue is related to the webview not receiving the F11 event or the app not supporting fullscreen for certain content types. There are no comments or PRs to guide, so initial investigation is needed.