lanl/singularity-eos
Should we remove forwarding references from PTE solvers?
オープン
#438 opened on 2024/11/29
bugclean-updiscussionhelp wantedinterfacequestion
Repository metrics
- Stars
- (36 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
The segfault on HIP was caused by an access-out-of-scope error caused by passing pointers by reference into the PTE solvers. See #437 . Perhaps we should consider removing the forwarding references and pass only by value into the PTE solvers (with the exception of PTE Solver Base, which requires pass-by-reference as it is used as the first part of the derived class constructors).
Ping @jhp-lanl @jdolence @dholladay00 @mauneyc-LANL and @rbberger for feedback