lance-format/lance

Python: fix broken fragment APIs

Open

#1,006 opened on 2023年6月22日

GitHub で見る
 (0 comments) (0 reactions) (1 assignee)Rust (695 forks)github user discovery
A-pythongood first issue

Repository metrics

Stars
 (6,582 stars)
PR merge metrics
 (平均マージ 6d 1h) (30d で 219 merged PRs)

説明

The APIs around getting and manipulating fragments are inconsistent with their return types.

In many cases, the type hint is wrong. For example, LanceFragment.create() claims to return LanceFragment (which would make sense), but instead returns _FragmentMetadata. Also odd that _FragmentMetadata has an underscore even though it is part of a public API.

We should refactor this to be consistent. Would also be nice to start enforcing the type hints with mypy.

コントリビューターガイド