kubernetes/minikube

profile list returns non-zero if a cluster is not running

Open

#6,743 opened on 2020年2月22日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)Go (31,799 stars) (5,222 forks)batch import
help wantedkind/bugkind/featurelifecycle/frozenpriority/backlog

説明

when I was looking at this intergeration test that failed because profile list says one of the clusters is not running yet...

https://storage.googleapis.com/minikube-builds/logs/6717/e653589/Docker_Linux.html#fail_TestFunctional%2fparallel%2fProfileCmd%2fprofile_list

and also one of the users who was using minikube in a test script,... made me think.

When are the resonable times to exit none-zero for profile list ?

currently we exit non-zero for the following:

  • If there is no profile .
  • if there are a few profiles are one of them has error to give status running.

コントリビューターガイド

技術スタック
go
領域
cli
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
needs investigation
前提条件
Go
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
35
調査方針
Investigate the current implementation of the `profile list` command in the minikube Go source code, likely in `cmd/minikube/cmd/profile list.go`. Understand the existing exit code logic and the cases where non zero is returned. Review the referenced integration test failure (https://storage.googleapis.com/minikube builds/logs/6717/e653589/Docker Linux.html#fail TestFunctional%2fparallel%2fProfileCmd%2fprofile list) to see the expected behavior. Participate in the issue discussion to clarify the desired exit code semantics for cases like a cluster not running.