kubernetes/minikube

make it obvious in terminal for user if using docker-env

Open

#6,489 opened on 2020年2月4日

GitHub で見る
 (22 comments) (0 reactions) (2 assignees)Go (31,799 stars) (5,222 forks)batch import
co/docker-envgood first issuekind/documentationkind/featurelifecycle/frozenpriority/backlog

説明

I was thinking as part of the eval $(minikube docker-env) we could pass something that changes the terminal Prompt so it is obvious for the user they are usinf minikube's docker not their own docker.

maybe: something like:

medya@~ $ PS1="$PS1""(using minikube dockerd) $:"

that will try turn into

medya@~ $ (using minikube dockerd) $:

the minikube word would be profile name, this will also make it clear which profile's docker-env we are using.

helps with https://github.com/kubernetes/minikube/issues/6462 helps with https://github.com/kubernetes/minikube/issues/6437

also we could explicity set a ENV that says

USES_MINIKUBE_DOCKERD=PROFILE_NAME

コントリビューターガイド

技術スタック
goshell
領域
clideveloper experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
basic shell scripting
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
The issue proposes modifying the `eval $(minikube docker env)` command to change the terminal prompt or set an environment variable indicating the user is using minikube's Docker daemon. The implementation likely involves editing the `cmd/minikube/cmd/docker env.go` file or the associated shell script output. The suggestion is to add a line like `PS1="$PS1 (using minikube dockerd) $"` or export `USES MINIKUBE DOCKERD=PROFILE NAME`. Review the existing output format in the codebase and discuss which approach is cleaner. The issue has two assignees and many comments, indicating prior discussion but no resolution. Check the linked issues for additional context.