kubernetes/minikube

nerdctl-bin x86_64 package references wrong version variable

オープン

#23,436 opened on 2026/08/04

 (1 件のコメント) (0 件のリアクション) (1 人の担当者)Go (5,222 件のフォーク)batch import
good first issue

Repository metrics

Stars
 (31,799 個のスター)
PR merge metrics
 (平均マージ 12d 19h) (30d で 43 merged PRs)

説明

Bug

In deploy/iso/minikube-iso/arch/x86_64/package/nerdctl-bin/nerdctl-bin.mk, the NERDCTL_BIN_SOURCE line references NERDCTL_BIN_AARCH64_VERSION instead of NERDCTL_BIN_VERSION:

NERDCTL_BIN_VERSION = 2.3.5
...
NERDCTL_BIN_SOURCE = nerdctl-$(NERDCTL_BIN_AARCH64_VERSION)-linux-amd64.tar.gz

It should be:

NERDCTL_BIN_SOURCE = nerdctl-$(NERDCTL_BIN_VERSION)-linux-amd64.tar.gz

Impact

This currently works by accident because both architectures use the same nerdctl version, so NERDCTL_BIN_AARCH64_VERSION resolves correctly when both packages are configured. It would break if the versions ever diverged or if the x86_64 package were built in isolation.

Fix

Change line 10 of deploy/iso/minikube-iso/arch/x86_64/package/nerdctl-bin/nerdctl-bin.mk from:

NERDCTL_BIN_SOURCE = nerdctl-$(NERDCTL_BIN_AARCH64_VERSION)-linux-amd64.tar.gz

to:

NERDCTL_BIN_SOURCE = nerdctl-$(NERDCTL_BIN_VERSION)-linux-amd64.tar.gz

コントリビューターガイド