kubernetes/ingress-nginx
Distinguish wait-shutdown command from standard k8s SIGTERM
オープン
#6,287 opened on 2020/10/06
good first issuehelp wantedkind/featureneeds-triagepriority/backlog
Repository metrics
- Stars
- (15,199 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
As of v0.26.0, we can specify /wait-shutdown as a pre-stop hook in our deployment spec. As currently implemented, it sends SIGTERM to the nginx-ingress-controller process. https://github.com/kubernetes/ingress-nginx/blob/59a7f51cd4f0c41f214c520ca8b2a502946ed08e/cmd/waitshutdown/main.go#L29
Since SIGTERM is also what k8s sends when shutting down a pod, there is no way for us to really tell for sure from the logs whether the pre-stop hook was properly configured or not. For this reason, it would be better if wait-shutdown used a different signal.
/kind feature