kubernetes/ingress-nginx

Enabling Helm .Values.controller.opentelemetry.enabled prevents pods from being rescheduled on different nodes and cluster auto-scaling from working.

Open

#10,911 opened on 2024年1月24日

GitHub で見る
 (14 comments) (0 reactions) (1 assignee)Go (15,199 stars) (7,888 forks)batch import
area/docshelp wantedkind/documentationneeds-priorityneeds-triage

説明

What happened: Enabling .Values.controller.opentelemetry.enabled prevents pods from being rescheduled on different nodes and cluster auto-scaling from working.

What you expected to happen: Expected cluster auto-scaling to continue to reschedule ingres-nginx pods on different nodes

NGINX Ingress controller version (exec into the pod and run nginx-ingress-controller --version.): registry.k8s.io/ingress-nginx/controller:v1.9.5@sha256:b3aba22b1da80e7acfc52b115cae1d4c687172cbf2b742d5b502419c25ff340e

The helm chart adds emptyDir: {} here when the .Values.controller.opentelemetry.enabled is set to true: https://github.com/kubernetes/ingress-nginx/blob/0c3d52bade1219c1d61d486e44a91ded48766aac/charts/ingress-nginx/templates/controller-daemonset.yaml#L215

I think it should also add the annotation in podAnnotations area in the same file... cluster-autoscaler.kubernetes.io/safe-to-evict: "true" automatically in the helm chart when .Values.controller.opentelemetry.enabled or at least give a warning that you might want to consider adding it yourself because cluster autoscaling won't be able to move your ingress-nginx pods otherwise.

コントリビューターガイド

技術スタック
go
領域
devopsinfrastructureobservability
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
active
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Helm chart understandingKubernetes pod annotationscluster autoscaler basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
The issue concerns the Helm chart in charts/ingress nginx/templates/controller daemonset.yaml where enabling OpenTelemetry adds an emptyDir but does not add a safe to evict annotation. The fix should add 'cluster autoscaler.kubernetes.io/safe to evict: "true"' in the podAnnotations section conditionally. Review the existing chart logic and ensure compatibility with other configurations. Consider also checking if the same issue exists for the deployment variant.