kernc/backtesting.py

SQN calculation not using expectancy?

Open

#558 opened on 2021年12月23日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)Python (863 forks)batch import
help wanted

Repository metrics

Stars
 (4,387 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

Hi,

It's good to see the stats include SQN. According to https://evilspeculator.com/tools-section/concepts/:

SQN = root(n) * expectancy / stdev(R)

but I suspect it's not correctly calculated:

https://github.com/kernc/backtesting.py/blob/77f4c46b82169c2689e1c4ad5994765556179eb2/backtesting/_stats.py#L139

as it's not using the result of expectancy:

https://github.com/kernc/backtesting.py/blob/77f4c46b82169c2689e1c4ad5994765556179eb2/backtesting/_stats.py#L138

Unless I am missing something?

Thanks!

コントリビューターガイド