keep-starknet-strange/madara-tsukuyomi

Feat: Show progress of docker pull

オープン

#30 opened on 2023/08/21

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)TypeScript (16 件のフォーク)auto 404
enhancementgood first issue

Repository metrics

Stars
 (21 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

docker.modem.followProgress has an onProgress event listener. We can use that to detect the progress of the Docker installation and show it to the user. Currently, we just show a simple infinite loader.

The progress event fired by Dockerode isn't a simple event with progress percentage, instead it contains the actual logs you see during docker pull. So we need to come up with a neat way to show the progress to the user. Some ideas

  • Calculate the total progress % using some formula
  • Show a dialog box which shows the logs as it is from the user

コントリビューターガイド