kedacore/keda
Replace `k8s.io/client-go/scale` with controller-runtime client
オープン
#4,013 opened on 2022/12/14
feature-requesthelp wantedstale-bot-ignore
Repository metrics
- Stars
- (10,372 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
Proposal
controller-runtime client will soon support accessing /scale subresource:
https://github.com/kubernetes-sigs/controller-runtime/pull/2094
https://github.com/kubernetes-sigs/controller-runtime/issues/172
Once a version of controller-runtime with this change is released we should use it and consolidate our codebase ->
replace k8s.io/client-go/scale with controller-runtime client.
It is in the ScaledObject controller and scale executor: https://github.com/kedacore/keda/blob/f4bee67f5a444338b7c2b93c7b762a27c348867b/controllers/keda/scaledobject_controller.go#L67 https://github.com/kedacore/keda/blob/f4bee67f5a444338b7c2b93c7b762a27c348867b/pkg/scaling/executor/scale_executor.go#L47