juspay/hyperswitch
GitHub で見る[Refactor]: [ACI] reuse utility functions from connector utils
Open
#7,927 opened on 2025年4月29日
A-connector-integrationC-refactorE-easygood first issue
Repository metrics
- Stars
- (42,690 stars)
- PR merge metrics
- (平均マージ 8d 12h) (30d で 212 merged PRs)
説明
Refactor Description
- In Hyperswitch, reusable and connector-agnostic functions used in connector integrations are added to crates/hyperswitch_connectors/src/utils.rs.
However, parts of the current ACI integration reimplement these functions instead of reusing them.
Possible Implementation
-
Review transformer.rs in the ACI connector to identify opportunities to reuse functions from
crates/hyperswitch_connectors/src/utils.rs. -
Replace the existing implementations with the corresponding reusable functions from the utils module where applicable.
Example
Current - shopper_result_url: item.router_data.request.router_return_url.clone(),
Expected - shopper_result_url: item.router_data.request.get_router_return_url().ok(),
Have you spent some time checking if this feature request has been raised before?
- I checked and didn't find a similar issue
Have you read the Contributing Guidelines?
- I have read the Contributing Guidelines
Are you willing to submit a PR?
None