juspay/hyperswitch
GitHub で見る[REFACTOR] Move Hardcoded Value to Constant for Max Invitations
Open
#5,938 opened on 2024年9月18日
A-usersC-refactorgood first issuehacktoberfest
Repository metrics
- Stars
- (42,690 stars)
- PR merge metrics
- (平均マージ 6d 22h) (30d で 213 merged PRs)
説明
Feature Description
In the current implementation, the value 10 is hardcoded when checking the number of invite requests in the code. To improve maintainability and avoid magic numbers, this value should be moved to a constant in crates/router/src/consts/user.rs.
Possible Implementation
- Create a new constant in crates/router/src/consts/user.rs to represent the maximum number of allowed invite requests.
- Refactor the code to replace the hardcoded value 10 with this new constant.
Have you spent some time checking if this feature request has been raised before?
- I checked and didn't find a similar issue
Submission Process:
- Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
- Once assigned, submit a pull request (PR).
- Maintainers will review and provide feedback, if any.
- Maintainers can unassign issues due to inactivity, read more here.
Refer here for Terms and conditions for the contest.