jsx-eslint/eslint-plugin-react

[jsx-key]: report on `yield`

Open

#352 opened on 2015年12月7日

GitHub で見る
 (2 comments) (1 reaction) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
enhancementhelp wantedrule

説明

Seems like yield <Component x={y}/> should be reported by jsx-key if there is no key prop.

This is valid:

for (let [idx, datum] of data.entries()) {
  yield (<MyComponent datum={datum} key={idx} />)
}

This is reported:

for (let [idx, datum] of data.entries()) {
  yield (<MyComponent datum={datum} />) // msg: need `key` prop
}

I can knock this out, if it makes sense.

(cc #332 as it will likely conflict with this if completed concurrently.)

コントリビューターガイド