jsx-eslint/eslint-plugin-react
GitHub で見るAdd configuration for no-did-update-set-state to allow usage inside condition
Open
#2,021 opened on 2018年10月18日
enhancementhelp wanted
Repository metrics
- Stars
- (8,630 stars)
- PR merge metrics
- (30d に merged PR はありません)
説明
As @gaearon has mentioned here and other places, using setState inside componenDidUpdate is acceptable, so long as it's within a conditional check.
Does it seem reasonable to allow a configuration option for this rule to allow setState usage within componenDidUpdate, so long as it's within a conditional check of some kind?
For example, this would pass here:
componentDidUpdate() {
if (!this.state.isEnabled) {
this.setState({ isEnabled: true })
}
}
but this would still fail:
componentDidUpdate() {
this.setState({ isEnabled: true })
}
An issue here would be that it's still not entirely guaranteed that more complex use cases wouldn't still end up in an infinite loop.