no-array-index-key not triggered when spreading props · jsx-eslint/eslint-plugin-react#1625

(2 comments) (0 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import

enhancementhelp wanted

説明

There's no warning or error when doing something like this:

people.map(({ name, email }, key) => {
  const props = {
    key,
    name,
    email,
  };

  return <Person {...props} />;
});

I realize this is a bit of an edge case, but maybe we can find a way to catch these uses as well.

技術スタック: javascriptreact
領域: toolingdeveloper experience
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: stale
明確さ: mostly clear
前提条件: Familiarity with ESLint plugin structureUnderstanding of AST traversal
初心者向け度: 20
調査方針: The issue is about the `no array index key` rule not triggering when the key is spread via props. To fix this, examine the rule implementation in `lib/rules/no array index key.js`. The rule currently checks for `key` prop directly on JSX elements but does not detect `{...props}` spreading. Investigate how other rules handle prop spreading, and consider adding a helper to look for `key` in object expressions used in JSX spread attributes. Also check the rule's test file (`tests/lib/rules/no array index key.js`) for existing test cases and add new ones covering spread scenarios.