Bug: jsx-closing-bracket-location autofix removes whitespace character · jsx-eslint/eslint-plugin-react#1501

(4 comments) (0 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import

bughelp wanted

説明

<div>
  foo </div>

Renders a space in HTML: <div>foo </div>

After fix is applied, it becomes:

<div>
  foo 
</div>

Note that there IS a space after foo in the output, however this space will typically be linted off by no-trailing-spaces rule, and even if it's not linted out of your source code, it will be ignored by React's JSX parser, meaning the output HTML will be <div>foo</div> 100% of the time.

tl;dr

<div>foo </div> becomes <div>foo</div>

コントリビューターガイド

技術スタック: javascriptreact
領域: frontenddeveloper experiencetooling
Issue 種別: bug
難度: 3
推定時間: half day
活動状況: stale
明確さ: clear
前提条件: ESLint plugin developmentReact JSX
初心者向け度: 50
調査方針: Investigate the `jsx closing bracket location` rule's autofix code. The bug is that when moving the closing bracket to a new line, a trailing space is lost. The fix should preserve the space character before the closing bracket. Look at the rule's implementation in the repo, likely in `lib/rules/jsx closing bracket location.js`. Write a test case matching the issue example and ensure the autofix keeps the space intact.