joshwcomeau/react-retro-hit-counter

More legible segments

オープン

#1 opened on 2018/01/28

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (5 件のフォーク)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (165 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

This component mimics a "seven-segment display": https://en.wikipedia.org/wiki/Seven-segment_display

I chose a simple implementation at first: each segment is exactly the same shape and size, and I'm just rotating them around.

Unfortunately, this means the end result isn't as legible as it could be, especially with thicker segments. Compare this component to another seven-segment display using trapezoids around the edge pieces:

current alternative

I think it would be good to move towards that alternative version, as the numbers are much easier to read.

コントリビューターガイド