josdejong/jsoneditor

Implement a way to trigger executing onEditable again

オープン

#1,261 opened on 2021/03/05

 (2 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (2,078 件のフォーク)batch import
featurehelp wanted

Repository metrics

Stars
 (12,263 個のスター)
PR merge metrics
 (PR metrics pending)

説明

We have a case where we dynamically switch the editor from read-only to editable. However, in code or text mode this isn't applied properly because the onEditable callback is only called on creation.

https://github.com/josdejong/jsoneditor/blob/1e79ead1ec96a9acfdb8b35097595a3da5a9bacc/src/js/textmode.js#L255-L256

This is not clear from the docs:

In modes text and code, the callback is invoked as editable(node) where node is an empty object (no field, value, or path). In that case the function can return false to make the text or code editor completely read-only.

If it's not possible to handle this dynamically, having to call .refresh() to update the mode also comes a long way. Currently we recreate the editor when we want to switch from read-only to editable.

コントリビューターガイド