jonas-schievink/rubble

Don't give up when missing the initial transmit window

Open

#77 opened on 2019年9月28日

GitHub で見る
 (0 comments) (2 reactions) (0 assignees)Rust (403 stars) (58 forks)user submission
area: link layergood first issuestatus: needs codetype: bug

説明

Currently the link layer will abort the connection when it does not receive the initial connect event:

https://github.com/jonas-schievink/rubble/blob/0c219f5fd1ef24cc6ca6f6e1edb02556e5fdd64f/rubble/src/link/connection.rs#L338-L345

This shouldn't happen. Instead, we should do what the comment suggests (and check it against the spec).

The effect of this bug is that establishing a connection can spuriously fail, so this is a reliability issue.

コントリビューターガイド

技術スタック
rust
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Basic understanding of RustFamiliarity with BLE connection establishment
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
The issue points to lines 338-345 in connection.rs (https://github.com/jonas schievink/rubble/blob/0c219f5fd1ef24cc6ca6f6e1edb02556e5fdd64f/rubble/src/link/connection.rs#L338 L345) where the code aborts on missing initial transmit window. The fix should implement the comment's suggestion and check against the Bluetooth specification to properly handle this scenario without aborting. Reviewing the BLE core spec and similar implementations would be necessary to determine the correct behavior.