joinmarket-webui/jam
GitHub で見る[v2] avoid recreating browser router on every app render
Open
#1,155 opened on 2026年2月27日
buggood first issuev2
Repository metrics
- Stars
- (325 stars)
- PR merge metrics
- (PR metrics pending)
説明
right now createBrowserRouter() is being called inside the App component body, which means a new router instance gets created on every render.
since App re-renders on state, context, and translation changes, this causes the router to be recreated repeatedly. react router expects the router instance to be stable, and recreating it can reset internal navigation state, interrupt pending fetchers, and potentially cause subtle routing bugs.
the router should be memoized with the correct dependencies or refactored so it is created once and remains stable across renders.