(1 comment) (1 reaction) (0 assignees)JavaScript (13,218 stars) (785 forks)batch import

bughelp wanted

説明

Expected Behavior

2021-04-07T09:36:55.000Z

# Expected Behavior this image ![example](https://user-images.githubusercontent.com/67194495/113842856-670faf80-9793-11eb-9d5d-867273fe6d3f.png) to something like this ![dithered_image](https://user-images.githubusercontent.com/67194495/113843205-ad650e80-9793-11eb-8681-4bc8d08b8e12.png) # Current Behavior this image ![example](https://user-images.githubusercontent.com/67194495/113843333-c8378300-9793-11eb-81b3-7c64953367d7.png) to this image ![dithered_image](https://user-images.githubusercontent.com/67194495/113843363-ce2d6400-9793-11eb-9e1a-aff35b66b790.png) there is just nothing happening # Failure Information (for bugs) the image is not being dithered ## Steps to Reproduce my code snippet: ``` Jimp.read('./server/images/example.png', async function (err, image) { async function dithering() { console.log('dithering', file) image.dither565() image.write(`./server/images/dithered_image.png`) file = `./server/images/dithered_image.png` } //... //... ``` 1. step 1: dither the image 2. step 2: see the result ## Context - Jimp Version: 0.16.1 - Operating System: Windows 10 64 bit - Node version: v14.16.0 ## Failure Logs no errors / logs

this image example to something like this dithered_image

Current Behavior

this image example to this image dithered_image there is just nothing happening

Failure Information (for bugs)

the image is not being dithered

Steps to Reproduce

my code snippet:


Jimp.read('./server/images/example.png', async function (err, image) {
            
            async function dithering() {
                console.log('dithering', file)

                image.dither565()
                image.write(`./server/images/dithered_image.png`)


                file = `./server/images/dithered_image.png`
            } 
     //...
     //...

step 1: dither the image
step 2: see the result

Context

Jimp Version: 0.16.1
Operating System: Windows 10 64 bit
Node version: v14.16.0

Failure Logs

no errors / logs

コントリビューターガイド

技術スタック: javascript
領域: backend
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: stale
明確さ: clear
前提条件: JavaScriptNode.jsJimp basics
初心者向け度: 70
調査方針: Investigate the implementation of the `dither565` method in Jimp. Check the source code for the dithering algorithm, likely in `packages/core/src/` or similar. Look for any changes in behavior between versions, especially since the user reports no errors nor logs. Consider adding debug logging to trace the pixel manipulation. Check if there are any existing test cases for dithering that might indicate the expected behavior.