Why there is no Regex Support for excludeList of nonProxyHost · jetty/jetty.project#8329

(10 comments) (0 reactions) (1 assignee)Java (3,701 stars) (1,913 forks)batch import

EnhancementHelp Wanted

説明

Code at line below should be enhanced: https://github.com/eclipse/jetty.project/blob/8102378e2d24b8117ed3a545c7579f79d35fc45a/jetty-client/src/main/java/org/eclipse/jetty/client/ProxyConfiguration.java#L180

Generally nonProxyHosts gets defined with wildcards like *.abc.com|*.svc.local etc.. so .equals doesn't help ! And apparently Jetty Client doesn't have any support for wildcard list of nonProxyHosts !!

PS: reactor-netty handles it pretty well, refer below: https://github.com/reactor/reactor-netty/blob/main/reactor-netty-core/src/main/java/reactor/netty/transport/ProxyProvider.java#L310

コントリビューターガイド

技術スタック: java
領域: backendapi
Issue 種別: feature
難度: 3
推定時間: 1-2 days
活動状況: needs maintainer response
明確さ: clear
前提条件: JavaHTTP proxy concepts
初心者向け度: 45
調査方針: The issue requests adding regex/wildcard support for nonProxyHosts in Jetty Client. The file to modify is ProxyConfiguration.java (line 180). Currently, it uses .equals() which fails for wildcard patterns like *.abc.com. A solution could implement pattern matching similar to reactor netty's ProxyProvider. Review the linked reactor netty code for reference. Discuss with maintainers about the desired pattern syntax and compatibility.