jazzband/django-silk

Profiles don't seem to be created

Open

#215 opened on 2017年10月4日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)Python (3,958 stars) (319 forks)batch import
help wanted

説明

Using the latest master version, there seems to me that the only way to get profiling is to decorate a method/function with the silk_profile decorator.

The only place where Profile objects are created is here, and it happens for every profile object given by the DataCollector.profiles method. Now those profile objects are only registered using the register_profile in the _finalise_queries method which is part of the silk_profile decorator. From what I found, the decorator is only used for dynamic profiling throughout the project.

Note that the .prof files are being generated correctly.

Am I doing something wrong here?

コントリビューターガイド

技術スタック
python
領域
backendperformance
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Django request lifecyclePython decoratorsSilk's profiling pipeline
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Investigate the middleware's profiling logic in silk/middleware.py to understand how requests are automatically profiled. Compare with the manual decorator path in silk/profiling/profiler.py. Determine why Profile objects are only created during the decorator's finalise queries method and not during normal request processing. Check if the DataCollector.profiles method is being called in the automatic path and if so, why Profiler objects are not registered.