jaredpalmer/after.js

Razzle as dev dependency?

オープン

#419 opened on 2021/01/10

 (5 件のコメント) (4 件のリアクション) (0 人の担当者)TypeScript (195 件のフォーク)github user discovery
after.jsgood first issue

Repository metrics

Stars
 (4,090 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

🚀 Feature request

All Razzle examples use Razzle package as dev dependency. Except AfterJS - it needs Razzle as regular dependency because of razzle-dev-utils.

Current Behavior

If Razzle stays as a dev dep, I get this error message in production build:

Error: Cannot find module 'razzle-dev-utils/logger'
 Require stack:
 -  /app/node_modules/@jaredpalmer/after/build/cjs/getAssets.js
 - /app/node_modules/@jaredpalmer/after/build/cjs/render.js
 - /app/node_modules/@jaredpalmer/after/build/cjs/index.js

Desired Behavior

I would like to add AfterJS to my Razzle based project without moving Razzle from dev to regular dependencies.

Suggested Solution

Is using razzle-dev-utils in AfterJS worth? Can it be replaced with something?

コントリビューターガイド