itzg/minecraft-server-charts

Missing values in helm templates

Open

#141 opened on 2023年1月24日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)Mustache (165 forks)github user discovery
good first issuehelp wanted

Repository metrics

Stars
 (391 stars)
PR merge metrics
 (PR metrics pending)

説明

In the helm chart, two values are missing, as previously added in Minecraft bedrock. https://github.com/itzg/docker-minecraft-bedrock-server/blob/ab51be217cf5f245fcb3239466f145af3a9422ba/property-definitions.json#L112

https://github.com/itzg/docker-minecraft-bedrock-server/blob/ab51be217cf5f245fcb3239466f145af3a9422ba/property-definitions.json#L116

I did not find those two values can be easily controlled in the helm chart values.

  "emit-server-telemetry": {
    "env": "EMIT_SERVER_TELEMETRY",
    "allowed": ["true","false"]
  },
  "enable-lan-visibility": {
    "env": "ENABLE_LAN_VISIBILITY",
    "allowed": ["true","false"]
  }

I expect this feature can be added.

コントリビューターガイド