ipfs/kubo

canonical method for checking locality of a block via coreAPI

Open

#6,726 opened on 2019年10月24日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)Go (13,906 stars) (2,725 forks)batch import
help wantedkind/enhancement

説明

Location

:wave: 👨‍👧‍👧! I'm looking for the best way to ask "hey is this block local"?

Given that we're in IPFS user land, we should be using core API for this stuff. Which means we're trying to do stuff that's easiest accomplished with a blockstore via coreapi.

Blockstore method that works exactly as we'd like:

https://github.com/ipfs/go-ipfs-blockstore/blob/3eee0dff760dea94c59381e9a18b9aa290361b28/blockstore.go#L36

Relevant coreAPI subsystem:

https://github.com/ipfs/interface-go-ipfs-core/blob/1c94e6217184ed07abab840143aa1f417e314c3d/block.go#L20-L37

Description

We also have the same question about complete DAGs, happy to file a separate issue if you'd prefer. I'd love to be pointed to the canonical methods of determining if a block or dag is local via core API.

Thanks!

コントリビューターガイド

技術スタック
go
領域
apibackend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
GoIPFS core APIblockstore
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
The issue asks for a canonical way to check if a block is local using the core API. The user points to the blockstore.Has method and the coreAPI block subsystem. To resolve, first examine the existing coreAPI block methods (see interface go ipfs core/block.go) and determine if there is already a method to check locality. If not, propose adding a method such as `IsLocal` or `Has` to the coreAPI block interface, and implement it in the Kubo repo. Also consider the question about complete DAGs. Reference the blockstore interface and ensure the new method uses it internally.