ipfs/ipfs-desktop

Ignore single left click on tray icon

Open

#1,772 opened on 2021年2月25日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,632 stars) (912 forks)batch import
P2area/windowsexp/beginnergood first issuehelp wantedstatus/ready

説明

  • OS: Windows
  • Version of IPFS Desktop: 0.14.0

Describe the bug After implementing opening of app's window on a double click on tray icon, a single click with left mouse button still opens the context menu even when doing double click. So, the first left click quickly opens the menu until the second left click is done.

To Reproduce Steps to reproduce the behavior:

  1. Do a left click on the tray icon and the context menu will appear.
  2. Do a left double click on the tray icon and the context menu will quickly appear on the first click and disappear on the second.

Expected behavior Usually Windows apps are designed so that if tray icon menu opens with the right click, the single left click is just ignored.

コントリビューターガイド

技術スタック
javascriptnodejs
領域
desktop
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
JavaScriptElectron Tray API
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
85
調査方針
The issue is about tray icon behavior on Windows. The fix likely requires modifying the tray click event handler in the Electron main process. Look for code that sets up the tray and its click listener, probably in a file like 'src/tray.js'. The expected behavior is to ignore single left clicks (only respond to right clicks) and optionally implement double click to open the app window. Inspect the existing code to see how the tray is created and where click events are handled, and test on Windows.