ionic-team/ionic-framework

feat: Improved types for react useIonModal

クローズ

#28,680 opened on 2023/12/11

 (8 件のコメント) (0 件のリアクション) (0 人の担当者)TypeScript (13,381 件のフォーク)batch import
help wantedpackage: reacttype: feature request

Repository metrics

Stars
 (52,503 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Prerequisites

Describe the Feature Request

useIonModal should type props parameter.

Describe the Use Case

useIonModal currently allows any for component props. This is dangerous and has caused many crashes and unintended behaviors in my experience.

Currently:

export declare function useIonModal(component: ReactComponentOrElement, componentProps?: any): UseIonModalResult;

Describe Preferred Solution

export declare function useIonModal<P>(component: React.ComponentClass<P> | React.FC<P>, componentProps?: P): UseIonModalResult;
export declare function useIonModal(component: React.ReactElement, componentProps?: any): UseIonModalResult;

Describe Alternatives

Leaving as-is

Related Code

No response

Additional Information

If you would accept this change, I would happily make a PR

コントリビューターガイド