iodide-project/iodide

Navigating between explore and report page with back button does not work

Open

#2,403 opened on 2019年10月30日

GitHub で見る
 (10 comments) (0 reactions) (1 assignee)JavaScript (1,483 stars) (147 forks)batch import
help wanted

説明

A common thing I do is to write some code in the "explore" mode, and check on the "report" mode occasionally. My first reaction to go from the report mode back into explore is to hit the back button, which navigates back to the previous page (not the explore view).

What I Did

  1. Start at https://alpha.iodide.io/ (the homepage)
  2. Click on "A Brief Tour through Iodide" (or any other notebook)
  3. Click on "REPORT" in the top right
  4. Click browser back button

What I Expected

I expect the page to navigate back to "EXPLORE", which is the last immediate view. An alternative is to provide the same dialog when "backspace" is pressed.

What Happened

I navigate back to the homepage without warning dialog, losing any computed state. This is particularly felt when running python-heavy notebooks.

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
blocked
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Reactbrowser history APISPA routing
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Investigate how the explore and report views are navigated, likely using React Router. Look at the router configuration and history management in the codebase. Check if there is an existing mechanism to trap the back button and switch views instead of navigating away. The issue is clear but has an assignee, so coordinate with them.