internetarchive/openlibrary

Edition's bookcover alt-text should pull author from work

Open

#486 opened on 2017年4月28日

GitHub で見る
 (26 comments) (0 reactions) (1 assignee)Python (4,626 stars) (1,172 forks)batch import
Affects: DataAffects: ServerAffects: UIGood First IssueLead: @cdriniNeeds: ResponsePriority: 3Type: Bug

説明

Correcting a work's author (e.g. https://openlibrary.org/works/OL3531880W/Living_with_Leviathan?b=4&a=3&_compare=Compare&m=diff ) also corrects the Alt-text for the work cover, (e.g. to alt="Cover of: Living with Leviathan by David Brian Smith" ) but fails to correct the Alt-text for the editions below it, instead leaving it untouched (e.g. as alt="Cover of: Living with Leviathan by David Buchanan Smith" ). Might this be why the edition is still found on searches for the old author spelling?

view-source:https://openlibrary.org/books/OL17631357M/Living_with_Leviathan shows the error at lines 349, 357, 371

Proposed fix: Ensure the edition alt-text author name uses the same source data as the rest of the edition interface, which takes the author attached to the work(if it exists)

コントリビューターガイド

技術スタック
python
領域
backendaccessibility
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic knowledge of PythonFamiliarity with OpenLibrary's data model (works vs editions)
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Focus on the template or view that generates the HTML for edition book covers. Look in the OpenLibrary codebase for where 'alt' attribute of cover images is set, likely in a Python template file (e.g., .html or .pt). The issue notes that the alt text for editions does not update when the work's author is corrected, while the work cover does. Compare how the work cover gets its author data versus the edition cover. Ensure that the edition alt text uses the same author source as the rest of the edition interface, which should be the work's author if available.