internetarchive/openlibrary

Use --no-install-recommends in dockerfiles

Open

#2,656 opened on 2019年11月19日

GitHub で見る
 (6 comments) (0 reactions) (1 assignee)Python (4,626 stars) (1,172 forks)batch import
Good First IssueLead: @cdriniModule: DockerNeeds: ResponsePriority: 3Theme: DevelopmentType: Refactor/Clean-up

説明

Anywhere we use apt-get install in our Dockerfiles, we should also add --no-install-recommends. According to https://ubuntu.com/blog/we-reduced-our-docker-images-by-60-with-no-install-recommends this creates smaller images which build faster. Note:

It is important to keep in mind that doing this could result in some missing libraries in your projects which you may have to add back explicitly, but this will ultimately give you more control in the dependencies in your project.

コントリビューターガイド

技術スタック
dockershell
領域
infrastructurebuild system
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
blocked
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic knowledge of DockerFamiliarity with apt get
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
The issue is assigned to someone and has no linked PRs. Review all Dockerfiles in the repository (e.g., Dockerfile, docker compose files) for apt get install commands. Add the no install recommends flag to each occurrence. Be aware that removing recommended packages may cause missing dependencies; test the resulting Docker images to ensure functionality. The maintainer's note advises that missing libraries may need to be added back explicitly.
Use --no-install-recommends in dockerfiles · internetarchive/openlibrary#2656 | Good First Issue