import-js/eslint-plugin-import

`import/order` not working well with direct parent index

Open

#483 opened on 2016年8月11日

GitHub で見る
 (2 comments) (3 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wantedimport/export ordering

説明

Hello there,

I'm trying to set up a config for the import/order but I have issues when using .. path to match with direct parent index (e.g. ../index.js).

This is the config I use:

'import/order': [ // Enforce a convention in module import order.
  'warn',
  {
    'groups': [
      'builtin',
      ['external', 'internal'],
      ['parent', 'sibling', 'index'],
    ],
    'newlines-between': 'always',
  },
],

And here is an example of where I get a wrong warning:

import moduleA from '../moduleA'; // import/order warning
import moduleB from '..';

It reports a warning on the first line: import/order: There should be at least one empty line between import groups. Thus, it is no more a problem when adding an ending / after module B's path:

import moduleA from '../moduleA';
import moduleB from '../';
// everything is fine

According to me it's a bug, as I don't have to declare import moduleA from '../moduleA/ to match an index.js file. What's your thoughts on this?

コントリビューターガイド