[BUG] `no-unused-modules` doesn't support the export-default-from syntax · import-js/eslint-plugin-import#1938

(0 comments) (0 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import

bughelp wanted

説明

When using the version 2.22.1, the syntax described in the ECMAScript Proposal export default from doesn't seem to be supported by the rule no-unused-modules:

// index.js
export Component from './Component';

$ eslint .
Oops! Something went wrong! :(

ESLint: 7.12.1

TypeError: Cannot read property 'name' of undefined
Occurred while linting /Users/me/project/src/components/index.js:2
    at /Users/me/project/node_modules/eslint-plugin-import/lib/rules/no-unused-modules.js:675:46
    at Array.forEach (<anonymous>)
    at /Users/me/project/node_modules/eslint-plugin-import/lib/rules/no-unused-modules.js:671:32
    at Array.forEach (<anonymous>)
    at updateImportUsage (/Users/me/project/node_modules/eslint-plugin-import/lib/rules/no-unused-modules.js:664:17)
    at Program:exit (/Users/me/project/node_modules/eslint-plugin-import/lib/rules/no-unused-modules.js:895:9)
    at /Users/me/project/node_modules/babel-eslint/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/me/project/node_modules/babel-eslint/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/Users/me/project/node_modules/babel-eslint/node_modules/eslint/lib/linter/node-event-generator.js:254:26)

As a workaround, we could use this syntax to achieve the same goal:

// index.js
export { default as Component } from './Component';

コントリビューターガイド

技術スタック: javascriptnodejs
領域: toolingdeveloper experience
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: fresh
明確さ: clear
前提条件: JavaScriptESLint plugin structureAST
初心者向け度: 75
調査方針: Focus on the file `lib/rules/no unused modules.js`, specifically the `updateImportUsage` function around lines 664-675. The error occurs because the code expects a `source` property on an export declaration, but the `export default from` syntax produces a different AST structure. Investigate the AST node for `export default from` (likely an `ExportNamedDeclaration` with a different `source` shape) and update the logic to handle it, possibly by checking for the new syntax or using a different property to get the exported name.