idyll-lang/idyll

React lifecycle warning

オープン

#711 opened on 2021/03/10

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (97 件のフォーク)batch import
ComponentsGood First PRRough EdgesRuntimehelp wanted

Repository metrics

Stars
 (1,977 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

Describe the bug Some components depend on React lifecycle methods that are being deprecated, see this warning:

Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.\n

To Reproduce Create the default idyll article and look at terminal and JS console.

Expected behavior There are no warnings from React. I believe the idyll-document component relies on this method, as well as several components in idyll-components, including at least table, maybe others.

コントリビューターガイド