hyperstack-org/hyperstack

Hyperspec to_js method broken

Open

#393 opened on 2021年3月31日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (43 forks)batch import
buggood first issue

Repository metrics

Stars
 (531 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

    def to_js(*args, &block)
      opal_compile(*process_params(*args, &block))
    end

needs to be

    def to_js(*args, &block)
      opal_compile(process_params(*args, &block).first)
    end

(second value from process_params is options for mounting, which opal_compile doesn't need)

Should have a simple spec anyway that says yes I returned a string with length > 0

コントリビューターガイド