hyperstack-org/hyperstack

webpacker integration does not pull in .css packs

Open

#266 opened on 2019年10月7日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (531 stars) (43 forks)batch import
bughelp wanted

説明

If you require css files in the client_only and client_and_server pack files, they do not get included in the required assets.

Not sure if this is practical or possible. Currently hyper-config pulls in the pack file by doing an opal require on them. But if you try to require a css file it doesnt' like it.

The work around is to add one or both these lines to the layouts, if you are requiring css assets in the pack files: <%= stylesheet_pack_tag 'client_only' %>
If you are requiring css libraries in the client_only.js pack file
and
<%= stylesheet_pack_tag 'client_and_server' %>
If you are requiring css libraries in the client_and_server.js pack file

コントリビューターガイド

技術スタック
rubyrailsjavascriptcss
領域
frontendbuild system
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Ruby on Railswebpackerhyperstack basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
25
調査方針
Investigate how hyperstack's hyper config processes pack files and why .css files are skipped. Look at the code that requires pack files in the Ruby gem. Consider modifying the require logic to include CSS assets or adding a webpacker configuration to handle stylesheet pack tags. The workaround suggests adding stylesheet pack tag manually in layouts, so the goal is to automate this.