huginn/huginn

Using an additional single quote in Liquid var causes process get stuck

オープン

#2,584 opened on 2019/08/14

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)Ruby (4,264 件のフォーク)batch import
bughelp wanted

Repository metrics

Stars
 (49,270 個のスター)
PR merge metrics
 (平均マージ 4d 2h) (30d で 15 merged PRs)

説明

Monkey-patch added here broke liquid template parse.

Example:

string = {
  "a": {
    "type": "text",
    "value": "{{ data['I'm using another single quote'] }}"
  },
  "b": {
    "type": "text",
    "value": "{{ data['some text'] }}"
  }
}.to_json
Liquid::Template.parse(string)

or:

string = {
  "a": {
    "type": "text",
    "value": "{{ data['I\'m using another single quote'] }}"
  },
  "b": {
    "type": "text",
    "value": "{{ data['some text'] }}"
  }
}.to_json
Liquid::Template.parse(string)

ref: https://github.com/Shopify/liquid/issues/1110

コントリビューターガイド