[Bug]: [macOS] Do not disturb triggered when focus icon in menu bar · hovancik/stretchly#1549

2025-01-21T08:04:28.000Z

### Version - [x] I'm using version 1.17.2 ### Known issues - [x] I've checked Known issues ### Existing issues - [x] I've checked Existing issues ### Advanced Preferences - [x] I've checked Advanced Preferences ### What operating system are you using? macOS ### Operating System Version Ventura 13.6.7 ### Reproduction steps 1. Set focus to "Always Show in Menu Bar" within control center 2. 3. ... **Reproduces how often:** [What percentage of the time does it reproduce?]: 100% ### Expected Behavior Stretchly should check which focus is set and only pause when dnd is set ### Actual Behavior Stretchly stays paused as long as the focus icon is visible in the menu bar as `NSStatusItem Visible FocusModes` returns true in this case. ### Relevant log output ```shell ``` ### Preferences ```shell ``` ### Additional information From what I can see, a [recent changes](https://github.com/hovancik/stretchly/commit/79ab66e90217071d780eb39499566e51faa8e94f#diff-598501ef0557788dbfc3ebc4ec5c7cffbadea55a9d2688f2ca796829093a502dR129) was deployed where it now uses `NSStatusItem Visible FocusModes` to check DND mode. From what I understand, this returns true if the focus icon is shown in the menu bar. Also, the focus icon can be shown in the menu bar even when no focus mode is set. A workaround is to check "show breaks even in Do Not Disturb" mode within preferences. ### Code of Conduct - [x] I agree to follow this project's Code of Conduct

(15 comments) (2 reactions) (0 assignees)JavaScript (3,892 stars) (410 forks)batch import

bughelp wanted

説明

Version

I'm using version 1.17.2

Known issues

I've checked Known issues

Existing issues

I've checked Existing issues

Advanced Preferences

I've checked Advanced Preferences

What operating system are you using?

macOS

Operating System Version

Ventura 13.6.7

Reproduction steps

Set focus to "Always Show in Menu Bar" within control center

... Reproduces how often: [What percentage of the time does it reproduce?]: 100%

Expected Behavior

Stretchly should check which focus is set and only pause when dnd is set

Actual Behavior

Stretchly stays paused as long as the focus icon is visible in the menu bar as NSStatusItem Visible FocusModes returns true in this case.

Relevant log output

Preferences

Additional information

From what I can see, a recent changes was deployed where it now uses NSStatusItem Visible FocusModes to check DND mode. From what I understand, this returns true if the focus icon is shown in the menu bar. Also, the focus icon can be shown in the menu bar even when no focus mode is set.

A workaround is to check "show breaks even in Do Not Disturb" mode within preferences.

Code of Conduct

I agree to follow this project's Code of Conduct

コントリビューターガイド

技術スタック: javascript
領域: desktop
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: active
明確さ: clear
前提条件: JavaScriptElectron
初心者向け度: 65
調査方針: Investigate the commit 79ab66e90217071d780eb39499566e51faa8e94f that introduced the NSStatusItem Visible FocusModes check. Understand the difference between showing the focus icon in the menu bar and actual Do Not Disturb being enabled. Modify the code to only pause when DND is set, not just when the focus icon is visible. See the discussion in comments for potential approaches.