hound-search/hound

`make test` fails if `db/` has contents.

Open

#363 opened on 2020年10月30日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,470 stars) (606 forks)batch import
buggood first issuehelp wanted

説明

If you start the houndd server, /db becomes populated with the contents of other repos. Both jest and go test currently crawl over /db and get confused by it, usually because there are naming collisions.

I think three things would make this a little better:

  1. make clean should also empty db/.
  2. jest should ignore db/, which seems easy to do in a jest-config.js file.
  3. go test should ignore db, which seems like we have to do manually, by using something like go test 'go list ./... | grep -v directoriesToSkip\` (I got that example from stack overflow).

A band-aid could be to just do 1 above and then run it before we run tests. That doesn't seem ideal, though, because we'd have to re-install node_modules between make clean and running the tests.

コントリビューターガイド

技術スタック
javascriptgoshelljest
領域
backendtestingdevops
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Go testingJest configurationMakefile basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Review the issue for proposed solutions: 1) add db/ cleanup to make clean, 2) configure jest to ignore db/ via jest.config.js or package.json, 3) modify go test command to exclude db/ (e.g., using 'go test $(go list ./... | grep v db)'). Check the repository's existing Makefile and test configuration files for integration points. Comment #2 may provide additional insights.
`make test` fails if `db/` has contents. · hound-search/hound#363 | Good First Issue