hound-search/hound

Keep repo filter after search

Open

#251 opened on 2017年5月24日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,470 stars) (606 forks)batch import
enhancementgood first issuehelp wanted

説明

Problem Description

Hound UI does not keep the repo filter after reload or redirect to the website

Steps to reproduce

  1. go to hound website
  2. filter for a specific repo
  3. press search
  • filter for repo is applied correctly
  1. press f5 and search again
  • filter is removed

Expected behavior

  • Repo filter is applied correctly after reload

I want to use hound search for a specific repo by linking directly to: [[https://hound.local/?repos=my-repo]]

Unfortunately after doing so the search term will again be searched over all repos.

I tried to fix it but the ui code in ui/assets/js/hound.js is too complex for me. It seems that the params are not overwritten correctly when the website is reloaded.

Regards

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
JavaScriptURL parameters handling
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Investigate how the repo filter parameter is handled in `ui/assets/js/hound.js`. The issue is that the repo filter from URL query string is not persisted across page reloads. Look at how search parameters are read and applied. Check if the filter is being correctly parsed from `window.location.search` and applied to the search state. The code likely resets parameters on initialization. A fix would involve reading the 'repos' query parameter on page load and passing it to the search function.