highlightjs/highlight.js

`noHighlightRe` should win out over `languageDetectRe`

Open

#3,700 opened on 2023年1月25日

GitHub で見る
 (12 comments) (0 reactions) (0 assignees)JavaScript (22,960 stars) (3,497 forks)batch import
enhancementgood first issuehelp welcomeparserversion-12

説明

If a class name matches noHighlightRe it should always be ignored - even if it otherwise looks correct and is also a match of languageDetectRe... this would allow you to use lang-* as your detect match but then also have an exclude list in the noHightlightRe regex.

IE, the block list overrides the allow list. This is an edge case. If no one steps up to work on this before v12 this will auto-close as it's such a small edge case (and also a breaking change).

Is your request related to a specific problem you're having? I am using highlight.js to with "hljs.highlightAll()", and get these warnings. image

The solution you'd prefer / feature you'd like to see added... an option like: excluded-languages: {mermaid, ...} or an option to disable these warnings.

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
familiarity with highlight.jsregex basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
Examine the core highlight.js source (likely src/core.js or similar) to understand how noHighlightRe and languageDetectRe are checked. The current logic probably checks languageDetectRe first, then noHighlightRe. A fix would reverse priority so that noHighlightRe wins. Ensure existing tests are updated accordingly. See issue comments for discussion on edge cases and the maintainer's note about potential breaking change.