highlightjs/highlight.js

(themes) "faded" comments should be optional, not default.

Open

#3,483 opened on 2022年2月15日

GitHub で見る
 (10 comments) (1 reaction) (0 assignees)JavaScript (3,497 forks)batch import
enhancementgood first issuehelp welcometheme

Repository metrics

Stars
 (22,960 stars)
PR merge metrics
 (平均マージ 6m) (30d で 2 merged PRs)

説明

I think perhaps for accessibility that a pass over ALL the comment styles in all (1st party, not Base16) themes and pulling them up to a 3 or 4.5 contrast and then recommend that those who want the common "i can barely see the comments" look/feel should apply opacity of their desired choosing to hljs-comment. That way we equally support both accessibility and user choice.

I'm going to split this into a separate issue and add it to the v12 list.

Update: Definitely seems like we should first update the theme checker tool to use APCA.

Originally posted by @joshgoebel in https://github.com/highlightjs/highlight.js/issues/3482#issuecomment-1040565915

コントリビューターガイド