hazelcast/hazelcast

Fix non-thread safe java.util.Date comparison in Predicates

Open

#8,828 opened on 2016年9月2日

GitHub で見る
 (8 comments) (0 reactions) (0 assignees)Java (5,737 stars) (1,795 forks)batch import
Module: IMapModule: QuerySource: InternalTeam: CoreType: Defectgood first issue

説明

The Comparable that's passed to a Predicate has to be thread-safe.

java.util.Date is a Java in-built class that implements the Comparable interface which is NOT thread safe.

The Predicate is sent to local and remote partitions. If there's more than one partition on each node (very likely) a Predicate instance will be re-used. It may lead to the corruption of the Date instance.

Main concern: We should create a wrapper of a Date to make it immutable and thread-safe whenever used in a Predicate.

Side concerns: Currently the comparison of java.util.Date, java.sql.Timestamp, java.sql.Time and java.sql.Time is not transitive between each combination of two of them. We should look into that too to make the comparison of such types better without conversion.

Fix will unblock #8035

コントリビューターガイド

技術スタック
java
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Javathread safety conceptsunderstanding of Predicate interface
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
Investigate the Predicate class and its usage of Comparable. The main fix involves creating an immutable wrapper for java.util.Date to ensure thread safety. Also examine the transitive comparison issue among Date, Timestamp, Time, and SqlDate. Look at relevant source files in the predicates package, and consider the unblocking dependency on issue #8035 for additional context.